sabi0 commented on code in PR #12982:
URL: https://github.com/apache/lucene/pull/12982#discussion_r1437800293
##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Exception {
PrefixCompletionQuery query =
new PrefixCompletionQuery(analyzer, new Term("suggest_field", "abc_"));
TopSuggestDocs suggest = indexSearcher.suggest(query, numLive, false);
- assertSuggestions(suggest, expectedEntries.toArray(new
Entry[expectedEntries.size()]));
+ assertSuggestions(suggest, expectedEntries.toArray(new Entry[0]));
Review Comment:
Currently it's a vararg method allowing both
```
assertSuggestions(suggest, entries.toArray(new Entry[0]));
```
and
```
assertSuggestions(suggest, new Entry("abc_" + num, num));
```
I could change it to accept a Collection and wrap all the single-Entry calls
with `List.of()`.
Would that be ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
