mikemccand commented on code in PR #12967:
URL: https://github.com/apache/lucene/pull/12967#discussion_r1435749223
##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java:
##########
@@ -3631,9 +3631,9 @@ public void testHighOrdsSortedSetDV() throws Exception {
}
private interface FieldCreator {
- public Field next();
+ Field next();
- public DocIdSetIterator iterator(IndexReader r) throws IOException;
Review Comment:
There is another PR about removing the not-needed `public` in interfaces I
think.
##########
lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java:
##########
@@ -236,7 +236,7 @@ synchronized void abort() throws IOException {
}
}
- final boolean flushOneDWPT() throws IOException {
+ boolean flushOneDWPT() throws IOException {
Review Comment:
Ahh because the class itself is already final, great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
