benwtrent commented on code in PR #12922:
URL: https://github.com/apache/lucene/pull/12922#discussion_r1423943933
##########
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##########
@@ -255,6 +255,11 @@ static VectorSimilarityScorer fromAcceptDocs(
new FilteredDocIdSetIterator(acceptDocs) {
@Override
protected boolean match(int doc) throws IOException {
+ // Advance the scorer
+ if (!scorer.advanceExact(doc)) {
+ return false;
+ }
+
Review Comment:
This tells me that none of the filtered cases drop to using exact search? If
they did they would match on docs that were actually filtered out.
Could you add a test exercising this path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
