epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1420763238
##########
lucene/CHANGES.txt:
##########
@@ -67,6 +67,8 @@ API Changes
* GITHUB#11023: Adding -level param to CheckIndex, making the old -fast param
the default behaviour. (Jakub Slowinski)
+* GITHUB#12180: Add Facets#getBulkSpecificValues method to get specific values
for multiple FacetLabel at once. (Egor Potemkin)
Review Comment:
Done! I'm never sure if I'm supposed to use plurals for class names in
sentences like this...
##########
lucene/facet/src/java/org/apache/lucene/facet/Facets.java:
##########
@@ -44,11 +50,17 @@ public abstract FacetResult getTopChildren(int topN, String
dim, String... path)
throws IOException;
/**
- * Return the count or value for a specific path. Returns -1 if this path
doesn't exist, else the
- * count.
+ * Return the count or value for a specific path. Returns -1 {@link
#MISSING_SPECIFIC_VALUE} if
Review Comment:
You are right, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
