dungba88 commented on code in PR #12844:
URL: https://github.com/apache/lucene/pull/12844#discussion_r1409183001
##########
lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java:
##########
@@ -330,6 +330,29 @@ public static int[] growExact(int[] array, int newLength) {
return copy;
}
+ /**
+ * Returns an array whose size is at least {@code minLength}, generally
over-allocating
+ * exponentially, but never allocating more than {@code maxLength} elements.
+ */
+ public static int[] growInRange(int[] array, int minLength, int maxLength) {
+ if (array.length >= minLength) {
+ return array;
+ }
+ if (minLength > maxLength) {
+ throw new IllegalArgumentException(
+ "requested minimum array length "
+ + minLength
+ + " is larger than requested maximum array length "
+ + maxLength);
+ }
+
+ int potentialLength = oversize(minLength, Integer.BYTES);
+ if (potentialLength > maxLength) {
+ return growExact(array, maxLength);
+ }
+ return growExact(array, potentialLength);
+ }
+
/**
* Returns an array whose size is at least {@code minSize}, generally
over-allocating
* exponentially
Review Comment:
Would it make sense if we delegate the existing `grow(int[], int)` to the
new one to avoid having double code path? Something like `return
growInRange(array, minSize, Integer.MAX_VALUE)` would work I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
