janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib
configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384807112
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -607,19 +609,31 @@ public PackageStoreAPI getPackageStoreAPI() {
public void load() {
log.debug("Loading cores into CoreContainer [instanceDir={}]",
loader.getInstancePath());
+ // Always add $SOLR_HOME/lib to the shared resource loader
+ Set<String> libDirs = new HashSet<>();
+ libDirs.add("lib");
+
+ if (!StringUtils.isBlank(cfg.getSharedLibDirectory())) {
+ List<String> sharedLibs =
Arrays.asList(cfg.getSharedLibDirectory().split("\\s*,\\s*"));
Review comment:
I tried `StrUtils.splitSmart()` but we don't need the smartness of not
splitting inside quotes etc, and it does not trim whitespace around comma. So
I'll keep this unless you know about a better split-util somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
