Copilot commented on code in PR #361: URL: https://github.com/apache/kvrocks-controller/pull/361#discussion_r2413568931
########## Dockerfile: ########## @@ -26,14 +26,23 @@ WORKDIR /kvctl COPY . . RUN make +FROM node:22 AS webui-build -FROM ubuntu:focal +WORKDIR /kvctl/webui + +COPY ./webui . + +RUN npm install && npm run deploy + +FROM node:22 Review Comment: The final stage uses 'node:22' without specifying a tag variant (e.g., 'alpine', 'slim'). This results in a larger image size compared to the previous 'ubuntu:focal' base. Consider using 'node:22-alpine' or 'node:22-slim' to reduce the final image size while maintaining the Node.js runtime needed for the webui. ```suggestion FROM node:22-alpine ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
