LindaSummer commented on code in PR #3172:
URL: https://github.com/apache/kvrocks/pull/3172#discussion_r2365918393
##########
src/commands/cmd_search.cc:
##########
@@ -540,9 +540,12 @@ class CommandFTTagVals : public Commander {
Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
const auto &index_name = args_[1];
const auto &tag_field_name = args_[2];
- auto field_values = GET_OR_RET(srv->index_mgr.TagValues(ctx, index_name,
tag_field_name, conn->GetNamespace()));
+ auto field_values = srv->index_mgr.TagValues(ctx, index_name,
tag_field_name, conn->GetNamespace());
+ if (!field_values.IsOK()) {
+ return field_values.ToStatus();
+ }
Review Comment:
Hi @PragmaTwice ,
Thanks for your update and suggestion!😊
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
