cyningsun commented on code in PR #3195:
URL: https://github.com/apache/kvrocks/pull/3195#discussion_r2365678979
##########
src/storage/redis_db.cc:
##########
@@ -183,17 +183,15 @@ rocksdb::Status Database::MDel(engine::Context &ctx,
const std::vector<Slice> &k
std::vector<rocksdb::Status> statuses(slice_keys.size());
std::vector<rocksdb::PinnableSlice> pin_values(slice_keys.size());
- storage_->MultiGet(ctx, ctx.GetReadOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
+ storage_->MultiGet(ctx, ctx.DefaultMultiGetOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
pin_values.data(), statuses.data());
for (size_t i = 0; i < slice_keys.size(); i++) {
if (!statuses[i].ok() && !statuses[i].IsNotFound()) return statuses[i];
if (statuses[i].IsNotFound()) continue;
Metadata metadata(kRedisNone, false);
- // Explicit construct a rocksdb::Slice to avoid the implicit conversion
from
- // PinnableSlice to Slice.
- auto s = metadata.Decode(rocksdb::Slice(pin_values[i].data(),
pin_values[i].size()));
+ auto s = metadata.Decode(pin_values[i]);
Review Comment:
hi @PragmaTwice Yes, the expression was not clear enough. It should be
stated as avoiding the redundant creation of rocksdb::Slice objects.
`rocksdb::Slice()` creates a rocksdb::Slice object, and then passing it by
value to `[[nodiscard]] rocksdb::Status Decode(Slice input);` will create
another new rocksdb::Slice object. If a PinnableSlice is passed directly, only
one rocksdb::Slice object is created when it is passed by value to
`[[nodiscard]] rocksdb::Status Decode(Slice input);`. Compared to the former,
the latter avoids creating one additional rocksdb::Slice object. Is this
understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
