sryanyuan commented on code in PR #3170:
URL: https://github.com/apache/kvrocks/pull/3170#discussion_r2348004995
##########
src/config/config.cc:
##########
@@ -307,6 +307,10 @@ Config::Config() {
{"rocksdb.max_compaction_bytes", false, new
Int64Field(&rocks_db.max_compaction_bytes, 0, 0, INT64_MAX)},
{"rocksdb.sst_file_delete_rate_bytes_per_sec", false,
new Int64Field(&rocks_db.sst_file_delete_rate_bytes_per_sec, 0, 0,
INT64_MAX)},
+ {"rocksdb.periodic_compaction_seconds", false,
+ new UInt64Field(&rocks_db.periodic_compaction_seconds,
kDefaultRocksdbPeriodicCompactionSeconds, 0, UINT64_MAX)},
+ {"rocksdb.ttl", false, new UInt64Field(&rocks_db.ttl,
kDefaultRocksdbTTL, 0, UINT64_MAX)},
Review Comment:
The default values `kDefaultRocksdbPeriodicCompactionSeconds` and
`kDefaultRocksdbTTL` are set to `UINT64_MAX-1`, consistent with RocksDB's
native defaults. Leaving them unconfigured preserves the TTL/periodic
compaction behaviors. Do you mean changing those config types to string and
accepting the "default" value? When "default" is set, do not pass the Kvrocks
config value to RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
