PragmaTwice commented on code in PR #3151:
URL: https://github.com/apache/kvrocks/pull/3151#discussion_r2313066707


##########
tests/gocase/unit/type/timeseries/timeseries_test.go:
##########
@@ -431,4 +431,75 @@ func testTimeSeries(t *testing.T, configs 
util.KvrocksServerConfigs) {
                _, err := rdb.Do(ctx, "ts.get", "nonexistent_key").Result()
                require.ErrorContains(t, err, "key does not exist")
        })
+
+       t.Run("TS.CREATERULE Error Cases", func(t *testing.T) {

Review Comment:
   I think we should also add test cases for happy path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to