zhixinwen commented on issue #3097: URL: https://github.com/apache/kvrocks/issues/3097#issuecomment-3161427225
I am able to reproduce it, there are several issues: 1. the test script we used does not actually wait for `WAIT`, it would keep sending `WAIT 1`. 2. previously I was assuming each connection would have only one `WAIT` being blocked (https://github.com/apache/kvrocks/blob/unstable/src/server/server.cc#L740), but that is not the case here and 3. KVRocks should stop processing additional commands while it is blocked by `WAIT`. Action item: 1. Disable read callbacks when connection is blocked. 2. Do not assume each connection would have only one `WAIT`. Even though after Action Item 1, it should not happen, we should program defensively. My comment in https://github.com/apache/kvrocks/issues/3097#issuecomment-3153004778 was wrong, and it was not related to this seg fault. However, it is still an issue and we should track it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
