zhixinwen commented on code in PR #3101:
URL: https://github.com/apache/kvrocks/pull/3101#discussion_r2255453590
##########
tests/gocase/integration/replication/replication_test.go:
##########
@@ -622,3 +625,126 @@ func TestSlaveLostMaster(t *testing.T) {
duration := time.Since(start)
require.Less(t, duration, time.Second*6)
}
+
+func TestWALDiscreteError(t *testing.T) {
Review Comment:
I managed to create a WAL with discrete sequence number to trigger the
error, but I cannot trigger the seg fault. I think it is because the seg fault
only happens when ack is sent back on the same connection after
`FeedSlaveThread::Stop` call and the time window is small.
I am leaving it here because it does no harm to test an extra case, but let
me know if there is better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
