git-hulk commented on code in PR #3075:
URL: https://github.com/apache/kvrocks/pull/3075#discussion_r2249081729
##########
src/cluster/replication.cc:
##########
@@ -203,6 +206,21 @@ void FeedSlaveThread::loop() {
Stop();
return;
}
+
+ // Check if this change would unblock any WAIT command
+ auto largest_unblockable_seq =
srv_->LargestTargetSeqToWakeup(batch.sequence);
+ if (largest_unblockable_seq > last_replconf_getack_seq_) {
+ // Send _getack to the slave to get acknowledgment
+ auto s = util::SockSend(conn_->GetFD(), redis::BulkString("_getack"),
conn_->GetBufferEvent());
+ if (!s.IsOK()) {
+ error("Write error while sending _getack to slave: {}", s.Msg());
+ Stop();
+ return;
+ } else {
+ last_replconf_getack_seq_ = largest_unblockable_seq;
Review Comment:
> The check in largest_unblockable_seq > last_replconf_getack_seq_ ensures
we would not set last_replconf_getack_seq_ back to zero when
largest_unblockable_seq is zero.
Yes, exactly. Thanks for your response and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
