PragmaTwice commented on code in PR #3075:
URL: https://github.com/apache/kvrocks/pull/3075#discussion_r2244232001
##########
src/cluster/replication.cc:
##########
@@ -608,28 +626,34 @@ ReplicationThread::CBState
ReplicationThread::tryPSyncReadCB(bufferevent *bev) {
}
}
-void ReplicationThread::sendReplConfAck(bufferevent *bev) {
- SendString(bev, redis::ArrayOfBulkStrings({"replconf", "ack",
std::to_string(storage_->LatestSeqNumber())}));
+void ReplicationThread::sendReplConfAck(bufferevent *bev, bool force) {
+ int64_t now = util::GetTimeStamp();
+
+ // If force is true, always send ack. Otherwise, check if it has been 1s
from last ack
+ if (force || (now - last_ack_time_secs_) >= 1) {
+ SendString(bev, redis::ArrayOfBulkStrings({"replconf", "ack",
std::to_string(storage_->LatestSeqNumber())}));
+ last_ack_time_secs_ = now;
+ }
}
ReplicationThread::CBState ReplicationThread::incrementBatchLoopCB(bufferevent
*bev) {
repl_state_.store(kReplConnected, std::memory_order_relaxed);
auto input = bufferevent_get_input(bev);
bool data_written = false;
+ bool force_ack = false;
while (true) {
switch (incr_state_) {
case Incr_batch_size: {
// Read bulk length
UniqueEvbufReadln line(input, EVBUFFER_EOL_CRLF_STRICT);
if (!line) {
if (data_written) {
- sendReplConfAck(bev);
+ sendReplConfAck(bev, force_ack);
}
return CBState::AGAIN;
}
incr_bulk_len_ = line.length > 0 ? std::strtoull(line.get() + 1,
nullptr, 10) : 0;
if (incr_bulk_len_ == 0) {
- error("[replication] Invalid increment data size");
Review Comment:
Why the error is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
