git-hulk commented on code in PR #3084:
URL: https://github.com/apache/kvrocks/pull/3084#discussion_r2244187789
##########
src/storage/compact_filter.cc:
##########
@@ -132,4 +135,85 @@ bool SubKeyFilter::Filter([[maybe_unused]] int level,
const Slice &key, const Sl
return IsMetadataExpired(ikey, metadata) || (metadata.Type() == kRedisBitmap
&& redis::Bitmap::IsEmptySegment(value));
}
+bool SearchFilter::Filter([[maybe_unused]] int level, const Slice &key,
[[maybe_unused]] const Slice &value,
+ [[maybe_unused]] std::string *new_value,
[[maybe_unused]] bool *modified) const {
+ auto db = stor_->GetDB();
+ // storage close the would delete the column family handler and DB
Review Comment:
```suggestion
// It would delete the column family handler and DB when closing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
