PragmaTwice commented on code in PR #3075:
URL: https://github.com/apache/kvrocks/pull/3075#discussion_r2241462161
##########
src/cluster/replication.cc:
##########
@@ -203,6 +206,21 @@ void FeedSlaveThread::loop() {
Stop();
return;
}
+
+ // Check if this change would unblock any WAIT command
+ auto largest_unblockable_seq =
srv_->LargestTargetSeqToWakeup(batch.sequence);
+ if (largest_unblockable_seq > last_replconf_getack_seq_) {
+ // Send replconf getack to the slave to get acknowledgment
+ auto s = util::SockSend(conn_->GetFD(), redis::BulkString("replconf
getack"), conn_->GetBufferEvent());
Review Comment:
I'm having concern since once we decide we pass `replconf getack` in this
way, we can hardly change it since some users may partially upgrade the version
of kvrocks in a cluster so compatibility matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
