jonasmao commented on issue #3074:
URL: https://github.com/apache/kvrocks/issues/3074#issuecomment-3116221934
> It will be recycled in compaction so here we don't need to manually delete
it.
metadata cf filter have no condition (size==0) to recycle ？other places ？
```
bool MetadataFilter::Filter([[maybe_unused]] int level, const Slice &key,
const Slice &value,
[[maybe_unused]] std::string *new_value,
[[maybe_unused]] bool *modified) const {
Metadata metadata(kRedisNone, false);
rocksdb::Status s = metadata.Decode(value);
auto [ns, user_key] = ExtractNamespaceKey(key, stor_->IsSlotIdEncoded());
if (!s.ok()) {
LOG(WARNING) << "[compact_filter/metadata] Failed to decode,"
<< ", namespace: " << ns << ", key: " << user_key << ",
err: " << s.ToString();
return false;
}
DLOG(INFO) << "[compact_filter/metadata] "
<< "namespace: " << ns << ", key: " << user_key
<< ", result: " << (metadata.Expired() ? "deleted" :
"reserved");
return metadata.Expired();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
