PragmaTwice commented on issue #3070: URL: https://github.com/apache/kvrocks/issues/3070#issuecomment-3105504584
> If I understand the algorithm correctly, replication_ack_seq_threshold=0 would make one function call send multiple acks which can further hurt performance. Hmmm nope. There should be at most one ACK in one call of `IncrementBatchLoop`. However, I don't use a count of times of `IncrementBatchLoop` is called, but use the difference on sequence numbers. This is because in my mind, the data changes may not be in same size in each `IncrementBatchLoop` (correct me if I'm wrong). Hence, in the first call the increase of seq number can be 1, but in the second call it may be 10. It should be better if we treat them differently, so a difference between two seq numbers can describe them well. For example, if the data changes are heavy, we can have more quick ACKs so that the WAIT command can perform better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
