PragmaTwice commented on code in PR #3072:
URL: https://github.com/apache/kvrocks/pull/3072#discussion_r2224163366
##########
src/storage/redis_metadata.h:
##########
@@ -364,3 +365,36 @@ class TDigestMetadata : public Metadata {
double Delta() const { return 1. / static_cast<double>(compression); }
};
+
+enum class TSDuplicatePolicy : uint8_t {
+ BLOCK = 0,
+ FIRST = 1,
+ LAST = 2,
+ MIN = 3,
+ MAX = 4,
+ SUM = 5,
+};
+
+class TimeSeriesMetadata : public Metadata {
+ public:
+ enum class ChunkType : uint8_t {
+ UNCOMPRESSED = 0,
+ COMPRESSED = 1,
+ };
+
+ uint64_t retention_time;
+ uint64_t chunk_size;
+ ChunkType chunk_type;
+ TSDuplicatePolicy duplicate_policy;
+ Slice source_key;
Review Comment:
`Slice` has no ownership. It's like a `string_view`.
Here I think we can hold an owned string so that we don't need to worry
about lifetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
