git-hulk commented on code in PR #3061:
URL: https://github.com/apache/kvrocks/pull/3061#discussion_r2218093139
##########
src/cluster/replication.cc:
##########
@@ -603,6 +667,7 @@ ReplicationThread::CBState
ReplicationThread::incrementBatchLoopCB(bufferevent *
util::StringToHex(batch.Data()));
return CBState::RESTART;
}
+ data_written = true;
Review Comment:
I'm not sure why do we need to call `sendReplConfAck` in other places? I
think it would be good to send the ack after applying the write batch only.
What I mean is to remove `data_written` and `sendReplConfAck` in other
places, and just call `sendReplConfAck` here. Can help to correct me if I
missed anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
