Copilot commented on code in PR #324:
URL:
https://github.com/apache/kvrocks-controller/pull/324#discussion_r2199782656
##########
controller/cluster.go:
##########
@@ -332,14 +332,14 @@ func (c *ClusterChecker) tryUpdateMigrationStatus(ctx
context.Context, clonedClu
sourceNodeClusterInfo, err :=
shard.GetMasterNode().GetClusterInfo(ctx)
if err != nil {
log.Error("Failed to get the cluster info from the
source node", zap.Error(err))
Review Comment:
[nitpick] Using `continue` here skips the current shard without logging
which shard was affected; consider including the shard index or identifier in
the log to aid future debugging.
```suggestion
log.Error("Failed to get the cluster info from the
source node", zap.Error(err), zap.Int("shard_index", i))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
