Ryan4253 commented on code in PR #3034:
URL: https://github.com/apache/kvrocks/pull/3034#discussion_r2165039264
##########
src/config/config.cc:
##########
@@ -720,6 +720,15 @@ void Config::initFieldCallback() {
}
return
srv->storage->SetOptionForAllColumnFamilies(TrimRocksDbPrefix(k), v);
}},
+ {"rocksdb.level0_slowdown_writes_trigger",
+ [this]([[maybe_unused]] Server *srv, [[maybe_unused]] const std::string
&k,
+ [[maybe_unused]] const std::string &v) -> Status {
+ if (rocks_db.level0_slowdown_writes_trigger == 0) {
+ rocks_db.level0_slowdown_writes_trigger =
rocks_db.level0_stop_writes_trigger;
+ }
+
+ return Status::OK();
Review Comment:
The original code does work since we pass the RocksDB later on open and
RocksDB would set the constants accordingly. However, I'll go ahead and switch
to explicitly calling SetDBOptions / SetCFOptions since that is what all the
other configs do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
