Ryan4253 opened a new pull request, #3034:
URL: https://github.com/apache/kvrocks/pull/3034

   ## Summary of Changes
   1. Setting rocksdb.level0_slowdown_writes_trigger to 0 actually disables 
slowdown
   2. Add comments documenting interaction between 
rocksdb.level0_slowdown_writes_trigger, rocksdb.level0_stop_writes_trigger, and 
rocksdb.level0_file_num_compaction_trigger
   
   ## Testing Plan
   ### Unit Test
   ```
   [----------] Global test environment tear-down
   [==========] 431 tests from 69 test suites ran. (71775 ms total)
   [  PASSED  ] 430 tests.
   [  SKIPPED ] 1 test, listed below:
   [  SKIPPED ] UseBitmap/RedisBitmapTest.BitfieldStringGetSetTest/0
   ```
   
   ### RocksDB Logs
   kvrocks.conf:
   ```
   # Soft limit on number of level-0 files. We slow down writes at this point. 
   # A value of 0 means that no writing slow down will be triggered by number 
   # of files in level-0. If the value is smaller than 
   # rocksdb.level0_file_num_compaction_trigger, this will be set to its value
   #
   # Default: 20
   rocksdb.level0_slowdown_writes_trigger 0
   
   # Maximum number of level-0 files. We stop writes at this point. If the value
   # is smaller than rocksdb.level0_slowdown_writes_trigger, this will be set to
   # its value.
   #
   # Default: 40
   rocksdb.level0_stop_writes_trigger 40
   ```
   
   RocksDB Logs:
   ```
   2025/06/20-14:00:59.514105 99478      
Options.level0_file_num_compaction_trigger: 16
   2025/06/20-14:00:59.514112 99478          
Options.level0_slowdown_writes_trigger: 40
   2025/06/20-14:00:59.514117 99478              
Options.level0_stop_writes_trigger: 40
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to