git-hulk commented on code in PR #2937:
URL: https://github.com/apache/kvrocks/pull/2937#discussion_r2077193729
##########
src/commands/cmd_zset.cc:
##########
@@ -1109,9 +1109,9 @@ class CommandZMScore : public Commander {
for (const auto &member : members) {
auto iter = mscores.find(member.ToString());
if (iter == mscores.end()) {
- values.emplace_back(conn->NilString());
+ values.emplace_back("");
} else {
- values.emplace_back(conn->Double(iter->second));
+ values.emplace_back(util::Float2String(iter->second));
Review Comment:
That's correct to use `redis::Array` instead of `MultiBulkString` because it
needs to return the double type in RESP3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
