SharonIV0x86 commented on code in PR #2909:
URL: https://github.com/apache/kvrocks/pull/2909#discussion_r2065791359
##########
src/storage/event_listener.cc:
##########
@@ -163,22 +166,23 @@ void
EventListener::OnBackgroundError(rocksdb::BackgroundErrorReason reason, roc
storage_->SetDBInRetryableIOError(true);
}
- LOG(ERROR) << fmt::format("[event_listener/background_error] reason: {},
bg_error: {}", reason_str, error_str);
+ error("[event_listener/background_error] reason: {}, bg_error: {}",
reason_str, error_str);
}
-void EventListener::OnTableFileDeleted(const rocksdb::TableFileDeletionInfo
&info) {
- LOG(INFO) << "[event_listener/table_file_deleted] db: " << info.db_name <<
", sst file: " << info.file_path
- << ", status: " << info.status.ToString();
+void EventListener::OnTableFileDeleted(const rocksdb::TableFileDeletionInfo
&info_) {
Review Comment:
@PragmaTwice Hi, i had to rename the function parameter to ``info_`` for
some functions as it was conflicting with the spdlog's ``info``.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
