LindaSummer commented on issue #2794: URL: https://github.com/apache/kvrocks/issues/2794#issuecomment-2736555410
> [@LindaSummer](https://github.com/LindaSummer?rgh-link-date=2025-03-19T09%3A58%3A20.000Z) I was trying to work on this, but it seems like the code just freezes on this particular line when trying to lock the key before merging the unmerged nodes. > > [kvrocks/src/types/redis_tdigest.cc](https://github.com/apache/kvrocks/blob/3e1b21b71dcb5d424c89204d05835a99e5d0fca3/src/types/redis_tdigest.cc#L193) > > Line 193 in [3e1b21b](/apache/kvrocks/commit/3e1b21b71dcb5d424c89204d05835a99e5d0fca3) > > LockGuard guard(storage_->GetLockManager(), ns_key); > Any guidance on this is appreciated. Hi @SharonIV0x86 , You could refer to [the last comment above your comment](https://github.com/apache/kvrocks/issues/2794#issuecomment-2684957429) and comment is #2799 PR description. We should only guard the merge part, for a fast testing, you can remove the lock guard and make this command a write command. But it's just for self-testing, the final command should be a read command, and we should lock the merge part with correct key. By the way, it will be better to confirm with @AntiTopQuark on his progress to reduce confliction. 😊 Best Regards, Edward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
