RiversJin commented on PR #2820:
URL: https://github.com/apache/kvrocks/pull/2820#issuecomment-2706176846

   > > > `LoadClusterNodes` -> `SetClusterNodes` -> `SetMasterSlaveRepl` -> 
`srv_->slot_migrator->SetStopMigrationFlag`
   > > > 
https://github.com/apache/kvrocks/blob/231b093c979ab80c11ac5433e52d43213dc94840/src/cluster/cluster.cc#L252
   > > > 
   > > > @git-hulk  here
   > 
   > Seems it has been checked if the `migrator` is null before accessing? see: 
https://github.com/apache/kvrocks/blob/231b093c979ab80c11ac5433e52d43213dc94840/src/cluster/cluster.cc#L250C15-L250C28
   
   Oops, it seems I've mixed up the differences between the private code of my 
current company and the community code ..
   However,according to the information above, there is another place that also 
relies on slot_migrator, so I'll first test locally to see if there is an issue 
with the current branch ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to