git-hulk commented on code in PR #2815:
URL: https://github.com/apache/kvrocks/pull/2815#discussion_r1982946160
##########
src/server/server.cc:
##########
@@ -853,6 +840,19 @@ void Server::cron() {
CleanupExitedSlaves();
recordInstantaneousMetrics();
}
+
+ assert(stop_);
Review Comment:
```
I20250226 11:50:45.351392 140030983013952 main.cc:50] Signal Terminated (15)
received, stopping the server
```
Only the main thread will handle the signal. After receiving the terminated
signal, the server->Stop() will be called, and it will then stop the
replication thread afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
