PragmaTwice commented on issue #2758: URL: https://github.com/apache/kvrocks/issues/2758#issuecomment-2628902065
Thank for your effort! It's valuable for Kvrocks. > Since libbacktrace is an extension of glibc and not defined in musl libc, the line find_package(Backtrace REQUIRED) in CMakeLists.txt should be removed. Yeah it can be removed. > Additionally, the dependency [cpptrace](https://github.com/jeremy-rifkin/cpptrace#library-back-ends) suggests using libdwarf for symbol resolution, which should be set as the default option. IIRC we currently use addr2line as the backtrace backend of cpptrace. For libdwarf it's a little complicated: it's LGPL licensed, and due to ASF policy, it's in [Category X](https://www.apache.org/legal/resolved.html#category-x). So currently we make it an optional and non-default dep, see here: https://github.com/apache/kvrocks/blob/b87827533396557bc84ee348e2b29674d02ddf64/cmake/cpptrace.cmake#L27-L32 > This header file is not available in musl libc. Adding a guard as shown below can resolve the issue: If we include it but didn't use it, it can be removed. Otherwise we should know which function we're using from execinfo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
