[
https://issues.apache.org/jira/browse/KUDU-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069906#comment-18069906
]
ASF subversion and git services commented on KUDU-3757:
-------------------------------------------------------
Commit 737e339d3813d1a520eb46b96ab91eb44555c025 in kudu's branch
refs/heads/master from Alexey Serbin
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=737e339d3 ]
KUDU-3757 usability improvement for unsafe/experimental flags
This changelist allows for keeping customization for an 'experimental'
or 'unsafe' flag when its effective value remains set as by default.
This is a follow-up to 27ac602108ab5e6b4e2211c2bfae3b36badc3121.
Change-Id: I78b6cc2a4611f3e8056e3d65658bc052f07e1f50
Reviewed-on: http://gerrit.cloudera.org:8080/24151
Reviewed-by: Marton Greber <[email protected]>
Tested-by: Marton Greber <[email protected]>
Reviewed-by: Zoltan Martonka <[email protected]>
> Allow specifying an experimental flag set to default value without requiring
> --unlock_experimental_flags
> --------------------------------------------------------------------------------------------------------
>
> Key: KUDU-3757
> URL: https://issues.apache.org/jira/browse/KUDU-3757
> Project: Kudu
> Issue Type: Improvement
> Components: CLI, master, tserver
> Reporter: Alexey Serbin
> Assignee: Alexey Serbin
> Priority: Major
>
> It turns out that adding 'experimental' or 'unsafe' flag to an already
> existing flag leads to unexpected results when the flag was used with its
> default (in most cases safe and tested) value. E.g., that happened to the
> '\-\-use_hybrid_clock' flag
> [1|https://github.com/apache/kudu/commit/27ac60210]: if specifying
> '\-\-use_hybrid_clock=true', it's necessary to also specify
> '\-\-unlock_unsafe_flags' [2|https://github.com/apache/kudu/commit/ab974c7da]
> Since the idea behind locking 'experimental' and 'unsafe' flags was to warn
> users when they override the safe and tested default values, it makes sense
> to issue the warning and/or exit on flag validation only if the custom
> setting deviates from the default value for such flags.
> [1] https://github.com/apache/kudu/commit/27ac60210
> [2] https://github.com/apache/kudu/commit/ab974c7da
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
