[ 
https://issues.apache.org/jira/browse/KUDU-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934088#comment-17934088
 ] 

ASF subversion and git services commented on KUDU-3201:
-------------------------------------------------------

Commit 1733cfc5adaa27e361e2f2df25a8d8c12d8c8710 in kudu's branch 
refs/heads/master from Alexey Serbin
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=1733cfc5a ]

KUDU-3647 more robust zlib wrapper code

This patch introduces much more robust error handling for both
zlib::{CompressLevel,Uncompress}() utility wrappers and fixes a few bugs
introduced along with other modifications in [1].  In addition, the code
now follows the documented API of zlib's inflate()/deflate() more
closely per docs [2] and example [3], while zlib::CompressLevel()
no longer allocates memory on the heap and uses a much smaller
stack-allocated buffer.  It seems that using a larger heap-allocated
buffer inadvertently hid the improper usage of zlib's deflate() API.

This patch adds a few test scenarios to cover the main functionality
of zlib::CompressLevel() and zlib::Uncompress(), and also a few specific
conditions attributed to truncated and corrupted input data that's fed
to zlib::Uncompress().

[1] https://issues.apache.org/jira/browse/KUDU-3201
[2] https://zlib.net/zlib_how.html
[3] https://zlib.net/zpipe.c

Change-Id: I5babcaf0a07c284d44f16201aa765e277b6464d3
Reviewed-on: http://gerrit.cloudera.org:8080/22568
Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
Tested-by: Alexey Serbin <ale...@apache.org>


> Support gzipped HMS notifications (GzipJSONMessageEncoder)
> ----------------------------------------------------------
>
>                 Key: KUDU-3201
>                 URL: https://issues.apache.org/jira/browse/KUDU-3201
>             Project: Kudu
>          Issue Type: Improvement
>          Components: hms
>    Affects Versions: 1.13.0
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>            Priority: Major
>             Fix For: 1.14.0
>
>
> In HIVE-20679 a new message encoder was added to Hive that gzips and based64 
> encodes notification messages. In HIVE-21307 the default encoder was changed 
> to use the gzip encoder, GzipJSONMessageEncoder.
> Though Hive 4 is not released, failures as a result of this new message 
> format were reported in IMPALA-8751. We should add support for the gzip 
> format to prevent future HMS sync issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to