[
https://issues.apache.org/jira/browse/KUDU-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931273#comment-17931273
]
ASF subversion and git services commented on KUDU-3639:
-------------------------------------------------------
Commit cf95975114e2ae38ad4e4cf0d81e2e59bafa49af in kudu's branch
refs/heads/master from gabriellalotz
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=cf9597511 ]
KUDU-3639 Add table operation functions follow-up
Refactored pointer usage to remove unnecessary std::optional<>, ensuring
consistency across function signatures. Introduced a dedicated timeout
flag with a default of 30 seconds to prevent excessive wait times. Moved
leader lock handling into helper functions for better code organization
and reuse.
Change-Id: I39ed6526fc66113667c21051972da191d4ed209b
Reviewed-on: http://gerrit.cloudera.org:8080/22529
Reviewed-by: Zoltan Chovan <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
> Implement {Delete/Alter/Create}Table Functions Without RpcContext
> -----------------------------------------------------------------
>
> Key: KUDU-3639
> URL: https://issues.apache.org/jira/browse/KUDU-3639
> Project: Kudu
> Issue Type: New Feature
> Reporter: Gabriella Lotz
> Assignee: Gabriella Lotz
> Priority: Major
>
> The CatalogManager::\{DeleteTableRpc, CreateTable, AlterTableRpc} functions
> currently rely on rpc::RpcContext to extract the username of the requestor
> for authorization. However, in the REST catalog API implementation,
> RpcContext is not used, and only the username is directly available.
> To support REST API functionality, new functions are required that replace
> RpcContext with an explicitly provided username while maintaining the same
> core logic for table operations.
> Requirements:
> * Create new functions:
> ** CatalogManager::DeleteTableWithUser
> ** CatalogManager::AlterTableWithUser
> ** CatalogManager::CreateTableWithUser
> * These functions should:
> ** Accept a username parameter instead of rpc::RpcContext.
> ** Implement the same authorization, logging, and HMS integration logic as
> their corresponding RPC versions (DeleteTableRpc, AlterTableRpc, and
> CreateTable).
> ** Refactor shared logic between the existing RPC functions and the new
> \{Delete/Alter/Create}TableWithUser functions into reusable helper functions
> to minimize code duplication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
