[ 
https://issues.apache.org/jira/browse/KUDU-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895487#comment-17895487
 ] 

ASF subversion and git services commented on KUDU-3623:
-------------------------------------------------------

Commit f80f6e9f5c28cb67148c3e6b1a439e2b2a4dd8ab in kudu's branch 
refs/heads/branch-1.17.x from Alexey Serbin
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=f80f6e9f5 ]

KUDU-3623 do not crash on invalid input for 'kudu table copy'

This patch adds code to handle invalid input for the --predicates flag
of the 'kudu table copy' tool.  Now, instead of crashing on any
non-expected input, the tool exists gracefully and reports an actionable
error message.  With that, now it's easier to understand what was wrong,
correct typos/mistakes, and re-run the tool again, eventually achieving
the desired goal.

A new test is added to cover the newly introduced functionality.

This is a follow-up to 0afeddf9e530762e0e47beb7428982763715c746.

Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Reviewed-on: http://gerrit.cloudera.org:8080/22009
Tested-by: Alexey Serbin <ale...@apache.org>
Reviewed-by: Zoltan Chovan <zcho...@cloudera.com>
Reviewed-by: Marton Greber <greber...@gmail.com>
(cherry picked from commit 89ebb94e4a1b79557b3d3e8482edcd0352bf6968)
Reviewed-on: http://gerrit.cloudera.org:8080/22019
Reviewed-by: Alexey Serbin <ale...@apache.org>


> The 'kudu table copy' CLI tool crashes on invalid user input for filter 
> predicates
> ----------------------------------------------------------------------------------
>
>                 Key: KUDU-3623
>                 URL: https://issues.apache.org/jira/browse/KUDU-3623
>             Project: Kudu
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 1.9.0, 1.10.0, 1.10.1, 1.11.0, 1.12.0, 1.11.1, 1.13.0, 
> 1.14.0, 1.15.0, 1.16.0, 1.17.0, 1.17.1
>            Reporter: Alexey Serbin
>            Priority: Major
>
> It's quite funny and simultaneously very annoying that the {{kudu table 
> copy}} CLI tool crashes on malformed input for its {{\-\-predicates}} flag.
> When encountering an invalid input from a user, the tool should at least:
>  * not crash, but exit gracefully returning non-zero exit code
>  * provide actionable error message to the user, so they are able to fix 
> typos/mistakes and run the tool again, eventually achieving the desired result



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to