[ 
https://issues.apache.org/jira/browse/KUDU-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835751#comment-17835751
 ] 

ASF subversion and git services commented on KUDU-3433:
-------------------------------------------------------

Commit 9de4325a1a62f05ff29e6000daf60df4ef622e24 in kudu's branch 
refs/heads/branch-1.17.x from kedeng
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=9de4325a1 ]

KUDU-3433 Fix flakiness in 
ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks

The reason for the flakiness of the unit test is that we did not consider corner
cases, namely, the time reserved from detecting a table in soft-deleted state
until the execution of deletion, during which some operations may occur. We need
to reserve more time.

However, in order to verify that FLAGS_table_reserve_seconds is indeed 
effective,
the additional time cannot be too long. Taking these two factors into 
consideration,
I added one second of waiting time and performed multiple tests locally using 
the
gtest_repeat parameter to ensure that this modification is effective.

Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Reviewed-on: http://gerrit.cloudera.org:8080/21268
Tested-by: Alexey Serbin <ale...@apache.org>
Reviewed-by: Alexey Serbin <ale...@apache.org>
(cherry picked from commit e5f3d2b19e7a210f64e76584fbe53454886668cb)
Reviewed-on: http://gerrit.cloudera.org:8080/21272
Reviewed-by: Yingchun Lai <laiyingc...@apache.org>


> ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks is flaky
> -----------------------------------------------------------------
>
>                 Key: KUDU-3433
>                 URL: https://issues.apache.org/jira/browse/KUDU-3433
>             Project: Kudu
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Alexey Serbin
>            Priority: Major
>             Fix For: 1.18.0
>
>         Attachments: client-test.2.txt.xz, client-test.3.txt.xz, 
> client-test.4.txt.xz
>
>
> The {{TestDeleteWithDeletedTableReserveSecondsWorks}} in {{client-test}} 
> sometimes fails with the following message:
> {noformat}
> src/kudu/client/client-test.cc:5436: Failure      
> Value of: tables.empty()                                                      
>   
>   Actual: false                                                               
>   
> Expected: true
> {noformat}
> I'm attaching a full log for reference.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to