[
https://issues.apache.org/jira/browse/KUDU-944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon resolved KUDU-944.
------------------------------
Resolution: Won't Fix
Fix Version/s: n/a
Now that we've released an API I don't think we can change these
> All builder objects should return pointers or references consistently
> ---------------------------------------------------------------------
>
> Key: KUDU-944
> URL: https://issues.apache.org/jira/browse/KUDU-944
> Project: Kudu
> Issue Type: Bug
> Components: client
> Affects Versions: Feature Complete
> Reporter: Adar Dembo
> Fix For: n/a
>
>
> We have some builder objects whose methods return references to 'this', and
> others that return pointers. For the sake of a consistent API, we should pick
> one approach and apply it throughout.
> Arguments for returning pointers:
> * Better adheres to the google style guide.
> * More elegant when the builder itself can only be obtained by pointer (i.e.
> allocated via factory method or another object and has no public
> constructors).
> Arguments for returning references:
> * More elegant when the builder can be and is typically declared on the stack.
> I think pointers win out, though I'm open to discussion.
> Note that there are several other builders in the Kudu codebase that may be
> worth changing too. ThreadPoolBuilder is one that comes to mind.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
