Joe McDonnell created IMPALA-13979:
--------------------------------------

             Summary: Remove unused boost shared_ptr, etc headers
                 Key: IMPALA-13979
                 URL: https://issues.apache.org/jira/browse/IMPALA-13979
             Project: IMPALA
          Issue Type: Task
          Components: Backend
    Affects Versions: Impala 5.0.0
            Reporter: Joe McDonnell


We don't actually use boost::shared_ptr, but we include boost/shared_ptr.hpp in 
several files:
{noformat}
be/src/catalog/catalog-server.h:#include <boost/shared_ptr.hpp>
be/src/rpc/TAcceptQueueServer.h:#include <boost/shared_ptr.hpp>
be/src/rpc/thrift-client.h:#include <boost/shared_ptr.hpp>
be/src/rpc/thrift-server.h:#include <boost/shared_ptr.hpp>
be/src/rpc/thrift-util.h:#include <boost/shared_ptr.hpp>
be/src/service/impala-server.h:#include <boost/shared_ptr.hpp>
be/src/statestore/statestore-subscriber.h:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslClientTransport.cpp:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslClientTransport.h:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslServerTransport.cpp:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslServerTransport.h:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslTransport.cpp:#include <boost/shared_ptr.hpp>
be/src/transport/TSaslTransport.h:#include <boost/shared_ptr.hpp>
{noformat}
While we're fixing this, some of those files have boost/scoped_ptr.hpp included 
without needing it. Also, common/names.h includes boost/version.hpp without 
needing it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to