[ 
https://issues.apache.org/jira/browse/IGNITE-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025826#comment-17025826
 ] 

Ivan Pavlukhin commented on IGNITE-12583:
-----------------------------------------

[~vladsz83], I can suggest one little improvement for parameterized tests. It 
is using {{name}} property of {{Parameterized.Parameters}} annotation. With it 
we can make test names descriptive, it can help to diagnose failed tests in 
future. You can find a nice usage example in 
{{org.apache.ignite.internal.processors.cache.mvcc.CacheMvccSelectForUpdateQueryBasicTest}}.

> Parametrization of JdbcThinBulkLoadAbstractSelfTest
> ---------------------------------------------------
>
>                 Key: IGNITE-12583
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12583
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Vladimir Steshin
>            Assignee: Vladimir Steshin
>            Priority: Minor
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> org.apache.ignite.jdbc.thin.JdbcThinBulkLoadAbstractSelfTest is extended 
> several times using just parameter-assigning-getters like 
> {code:java}
> protected CacheMode cacheMode() { return CacheMode.REPLICATED; }
> protected CacheAtomicityMode atomicityMode() { return 
> CacheAtomicityMode.TRANSACTIONAL;}
> protected boolean nearCache() { return false; }
> {code}
> Should go with params instead.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to