[
https://issues.apache.org/jira/browse/IGNITE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024983#comment-17024983
]
Nikolay Izhikov commented on IGNITE-12576:
------------------------------------------
LGTM.
[~ibessonov] Please, rerun TC, and I will gather yardstick benchmarks to check
there is no performance drop.
> [IEP-35] TCP communication metrics use node ID instead of consistent ID
> -----------------------------------------------------------------------
>
> Key: IGNITE-12576
> URL: https://issues.apache.org/jira/browse/IGNITE-12576
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: IEP-35
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> TcpCommunicationMetricsListener uses nodeId for metrics name. consistentId
> should be used instead.
> Also all metrics for registry should be created at once before registry added
> to GridMetricManager. There is no need in separate initialization for sent
> and received counters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
