[
https://issues.apache.org/jira/browse/IGNITE-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835577#comment-16835577
]
Alexei Scherbakov commented on IGNITE-11256:
--------------------------------------------
[~antonovsergey93]
I reviewed your contribution. My comments:
1. No need to implement metrics aggregation for readOnlyMode and
readOnlyModeDuration_._ They will be almost same for all nodes. __ Better move
them to IgniteMXBean and in addition implement readOnly(boolean) method to
allow read-only mode switching from JMX. Look for
{{org.apache.ignite.mxbean.IgniteMXBean#active(boolean)}}
2. It might be good to have a way to activate grid in read-only state. This
could be achieved by adding new configuration property like
readOnlyAfterActivation and something like --activate read-only in control.sh
3. Fix logging like: log("Cluster is active" + (readOnly ? " (read-only)" :
""));
4. Fix logging like: log("Read-only mode is " + (readOnly ? "enabled" :
"disabled"));
5. Fix message like: Failed to perform cache operation (cluster is in read-only
mode)
6. U.hasCause is redundant and should be erased. We already have
{{org.apache.ignite.internal.util.typedef.X#hasCause(java.lang.Throwable,
java.lang.String, java.lang.Class<?>...)}}
7. Documentation on new public methods {{IgniteCluster.readOnly*}} could be
improved.
8. You should create a ticket for missing bindings in .NET module.
Otherwise looks good. [~tledkov-gridgain] could your review SQL related changes
?
> Implement read-only mode for grid
> ---------------------------------
>
> Key: IGNITE-11256
> URL: https://issues.apache.org/jira/browse/IGNITE-11256
> Project: Ignite
> Issue Type: Improvement
> Reporter: Alexei Scherbakov
> Assignee: Sergey Antonov
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Should be triggered from control.sh utility.
> Useful for maintenance work, for example checking partition consistency
> (idle_verify)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
