[
https://issues.apache.org/jira/browse/IGNITE-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718961#comment-16718961
]
ASF GitHub Bot commented on IGNITE-4111:
----------------------------------------
GitHub user NSAmelchev opened a pull request:
https://github.com/apache/ignite/pull/5650
IGNITE-4111 Fix NPE on client connected before disco impl initialized
It happens when someone client connect before discovery impl started.
- add fix (return empty collection)
- add test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NSAmelchev/ignite ignite-4111_fix_npe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5650
----
commit 3c57f869fdb9124a4fb46dc46ab1206eaddc4bd2
Author: NSAmelchev <nsamelchev@...>
Date: 2018-12-12T11:57:33Z
Fix issue
commit 3c635c6def95a8862f2fac56aa18a1afb534f032
Author: NSAmelchev <nsamelchev@...>
Date: 2018-12-12T13:07:37Z
Move test
----
> Communication fails to send message if target node did not finish join process
> ------------------------------------------------------------------------------
>
> Key: IGNITE-4111
> URL: https://issues.apache.org/jira/browse/IGNITE-4111
> Project: Ignite
> Issue Type: Bug
> Components: general
> Reporter: Semen Boikov
> Assignee: Amelchev Nikita
> Priority: Minor
> Fix For: 2.8
>
> Attachments: test onFirstMessage hang.log
>
>
> Currently this scenario is possible:
> - joining node sent join request and waits for
> TcpDiscoveryNodeAddFinishedMessage inside ServerImpl.joinTopology
> - others nodes already see this node and can send messages to it (for example
> try to run compute job on this node)
> - joining node can not receive message: TcpCommunicationSpi will hang inside
> 'onFirstMessage' on 'getSpiContext' call, so sending node will get error
> trying to establish connection
> Possible fix: if in onFirstMessage() spi context is not available, then
> TcpCommunicationSpi should send special response which indicates that this
> node is not ready yet, and sender should retry after some time.
> Also need check internal code for places where message can be unnecessarily
> sent to node: one such place is
> GridCachePartitionExchangeManager.refreshPartitions - message is sent to all
> known nodes, but here we can filter by node order / finished exchage version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
