[ 
https://issues.apache.org/jira/browse/IGNITE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695807#comment-16695807
 ] 

Ignite TC Bot commented on IGNITE-10191:
----------------------------------------

{panel:title=Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=2377453]]

{panel}
[TeamCity Run All 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2369467&buildTypeId=IgniteTests24Java8_RunAll]

> Incorrect comparison of lists in 
> RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility
> ----------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10191
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10191
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
>
>
> RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility (in 
> current codebase muted by renaming to {{_testAffinityCompatibility}}) looks 
> troublesome: apparent bug is incorrect comparison of lists expecting elements 
> to be always in the same order which doesn't look like the case for the 
> tested API:
> {code}            List<List<ClusterNode>> assignment0 = 
> assignPartitions(aff0, nodes, null, backups, 0).get2();
>                   List<List<ClusterNode>> assignment1 = 
> assignPartitions(aff1, nodes, null, backups, 0).get2();
>                   assertEquals (assignment0, assignment1);
> {code}
> Though test kept failing even after I experimented with replacing comparison 
> to one that was insensitive to the order of list elements.
> Brief checking of code intended to be tested suggests that maybe it isn't 
> even supposed to be deterministic - in case if this is correct test should be 
> very thoroughly redesigned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to