[
https://issues.apache.org/jira/browse/IGNITE-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686590#comment-16686590
]
ASF GitHub Bot commented on IGNITE-10253:
-----------------------------------------
GitHub user devozerov opened a pull request:
https://github.com/apache/ignite/pull/5395
IGNITE-10253
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10253
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5395
----
commit f9b0ad32766da4bc93447eef9aba6a864321a276
Author: devozerov <vozerov@...>
Date: 2018-11-14T14:26:18Z
Done.
commit 03841bc9caa57711246f435d960beb9808885e4c
Author: devozerov <vozerov@...>
Date: 2018-11-14T14:27:13Z
Done.
----
> Merge SqlQuery logic with SqlFieldsQuery
> ----------------------------------------
>
> Key: IGNITE-10253
> URL: https://issues.apache.org/jira/browse/IGNITE-10253
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Vladimir Ozerov
> Assignee: Vladimir Ozerov
> Priority: Major
> Fix For: 2.8
>
>
> Currently execution of {{SqlQuery}} query is very non-trivial. First, it is
> complex to understand. Second, it duplicates code. Third, the most important
> - it is buggy. Because when new logic is added to {{SqlFieldsQuery}} it is
> not added to {{SqlQuery}} with high probability. Moreover, we even have
> discrepancies between local and non-local modes. E.g. it has different value
> conversion logic.
> We need to do the following:
> 1) Remove all {{SqlQuery}}-specific logic from {{GridQueryProcessor}} and
> {{IgniteH2Indexing}}
> 2) Make {{SqlQuery}} work as follows:
> - generate {{SqlFieldsQuery}} from {{SqlQuery}}
> - execute it
> - convert results to K-V pairs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
