[ 
https://issues.apache.org/jira/browse/IGNITE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686144#comment-16686144
 ] 

ASF GitHub Bot commented on IGNITE-10184:
-----------------------------------------

GitHub user aliskhakov opened a pull request:

    https://github.com/apache/ignite/pull/5390

    IGNITE-10184: Fixed type conflict check test in public schema.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aliskhakov/ignite ignite-10184

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5390
    
----
commit ccbac72bc2dd454cb47f15dbe2a968490d025fe1
Author: Albert Iskhakov <aliskhakov@...>
Date:   2018-11-13T08:51:04Z

    IGNITE-10184: Fixed type conflict check test in public schema.

commit b92930c5e5082ad319c4128e7e4054a224d365c8
Author: Albert Iskhakov <aliskhakov@...>
Date:   2018-11-13T17:54:43Z

    IGNITE-10184: Unnecessary checks are removed.

commit caa1234c4fe3818d6368db0c0bf023491a6bc9d4
Author: Albert Iskhakov <aliskhakov@...>
Date:   2018-11-13T18:02:36Z

    IGNITE-10184: Fixed the order of imports.

----


> Missed TODO: IGNITE-5380 uncomment after fix
> --------------------------------------------
>
>                 Key: IGNITE-10184
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10184
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Ryabov Dmitrii
>            Assignee: Albert Iskhakov
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.8
>
>
> Ticket is resolved, so test 
> {{SqlSchemaSelfTest._testTypeConflictInPublicSchema}} should be renamed 
> (remove "\_" symbol) and fixed - this test should check that second cache 
> creation throws exception about conflict in the schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to