[
https://issues.apache.org/jira/browse/IGNITE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexey Kuznetsov reassigned IGNITE-9569:
----------------------------------------
Resolution: Fixed
Assignee: Pavel Konstantinov (was: Alexey Kuznetsov)
Looks good to me. Merged to master.
[~pkonstantinov] Please do a smoke test of Web Console.
Nothing was changed in functionality, but many internal things was refactored
and we need to make sure that Web Console works as expected (no errors in
console).
> Web console: use $inject for DI instead of arrays
> -------------------------------------------------
>
> Key: IGNITE-9569
> URL: https://issues.apache.org/jira/browse/IGNITE-9569
> Project: Ignite
> Issue Type: Improvement
> Components: wizards
> Reporter: Ilya Borisov
> Assignee: Pavel Konstantinov
> Priority: Minor
> Fix For: 2.8
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> To do:
> 1. Remove provider registration by array spread, like this:
> {code:java}
> .service(...serviceArray){code}
> Instead, use the canonical AngularJS approach:
> {code:java}
> .service('SeriveName', Service){code}
> 2. Do not use array Di syntax for exported symbols:
> {code:java}
> export ['IgniteVersion', 'Confirm', function directive (version,
> confirm){}]{code}
> Instead, use $inject property:
> {code:java}
> export function directive(version, confirm) {}
> directive.$inject = ['IgniteVersion', 'Confirm']{code}
>
> Motivation:
> The changes above will make older providers accessible to TypeScript, which
> in turn will allow to increase type coverage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
