[
https://issues.apache.org/jira/browse/IGNITE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587187#comment-16587187
]
Amelchev Nikita commented on IGNITE-8829:
-----------------------------------------
Hello [~v.pyatkov], [~dpavlov].
I have [prepared
PR|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-734] that fixes
configuration properties annotation and minor code style issues. [Tests
|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&tab=projectOverview&branch_IgniteTests24Java8=pull%2F4583%2Fhead]
look good.
Could you review, please?
> Some configuration properties of TcpCommunicationSpi does not annotated
> appropriately
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-8829
> URL: https://issues.apache.org/jira/browse/IGNITE-8829
> Project: Ignite
> Issue Type: Bug
> Reporter: Vladislav Pyatkov
> Assignee: Amelchev Nikita
> Priority: Major
> Fix For: 2.7
>
>
> When I checked all properties of TcpCommunicationSpi, I have found an issue
> with getting all configuration properties from code. Because a part of them
> not be a configured property, but a part of a real SPI life.
> I should was rid of these issues - all configurable properties must annotate
> as {{IgniteSpiConfiguration}}, but it not done for each.
> I have found at least two properties for which not be done:
> {{connectionsPerNode}}
> {{usePairedConnections}}
> and one property which not appropriate contract (it have only setter, but not
> getter):
> {{addressResolver}}
> Need to revised all properties CommunicationSpi and correct them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
