[
https://issues.apache.org/jira/browse/IGNITE-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563739#comment-16563739
]
ASF GitHub Bot commented on IGNITE-9124:
----------------------------------------
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4462
IGNITE-9124 Remove some dead code in ML module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4462
----
commit 6a92b001d65c8f39f88edf53c2487c4f32929f42
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-07-30T15:55:20Z
IGNITE-9124 Remove some dead code in math.exceptions and optimization
packages of ML module
- draft removal
-- verified with diffs overview and clean rebuild
commit 566b8e35e92d4aa39c5a79ff12f1defae9552d1e
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-07-31T14:00:09Z
IGNITE-9124 Remove some dead code in math.exceptions and optimization
packages of ML module
- removal completed
-- verified with diffs overview and clean rebuild
commit d71ddd0c9a987d98d10b38f9cf47b5ed237977e0
Author: Oleg Ignatenko <oignatenko@...>
Date: 2018-07-31T14:02:00Z
Merge branch 'master-ml' into ignite-9124
----
> Remove some dead code in math.exceptions and optimization packages of ML
> module
> -------------------------------------------------------------------------------
>
> Key: IGNITE-9124
> URL: https://issues.apache.org/jira/browse/IGNITE-9124
> Project: Ignite
> Issue Type: Task
> Components: ml
> Affects Versions: 2.6
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
> Fix For: 2.7
>
>
> Doing code coverage analysis discovered a bit of unused code:
> # in package
> [math.exceptions|https://github.com/apache/ignite/tree/master/modules/ml/src/main/java/org/apache/ignite/ml/math/exceptions]
> - classes ConvergenceException / MathIllegalStateException,
> InsufficientDataException, MathIllegalNumberException /
> NumberIsTooSmallException, NonPositiveDefiniteMatrixException,
> NonSymmetricMatrixException, NullArgumentException, SingularMatrixException,
> UnknownProviderException. In very early releases of ML these exceptions were
> used by some linear algebra code. This code has been very deeply reworked
> since but outdated exceptions were left hanging unattended, making rather
> confusing impression of the current API.
> # in
> [optimization|https://github.com/apache/ignite/tree/master/modules/ml/src/main/java/org/apache/ignite/ml/optimization]
> - interface Updater and two classes implementing it: BarzilaiBorweinUpdater
> and SimpleUpdater. This code has left hanging after cleanup that was made for
> release 2.5 (IGNITE-8232). Per my discussion with [~dmitrievanthony] (who
> most actively maintains this package) it would be better to remove this code.
> This task is to remove code mentioned above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
