[ 
https://issues.apache.org/jira/browse/IGNITE-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545429#comment-16545429
 ] 

ASF GitHub Bot commented on IGNITE-7165:
----------------------------------------

GitHub user Mmuzaf opened a pull request:

    https://github.com/apache/ignite/pull/4368

    IGNITE-7165 Rebalance control version holds by exchange thread

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Mmuzaf/ignite av-ignit-7165-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4368
    
----
commit e7a80e64da07af5c43c15fd5a7b1abe14d387057
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-05-30T16:46:06Z

    IGNITE-7165: add fix by suggestions AV

commit 9f7551c15ff62c187422095c0626200245c36a36
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-05-30T16:49:01Z

    IGNITE-7165: revert some

commit 0ab2d301bd5a100f8dcf1ef964786264ebee6b0a
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-05-30T17:39:04Z

    IGNITE-7165: changes due to else if

commit 0d37670990f6546202771313ba0869bd2b709ad4
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-07T12:56:45Z

    Merge branch 'master' into av-ignite-7165

commit 7673f1afdb7eaa79d4e03ee16083ee5ea4b92290
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-07T14:29:51Z

    IGNITE-7165: add assignments calculations compare

commit ce2ea0b397f416a764681259911adf04fa397d61
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-07T20:28:09Z

    IGNITE-7165: hasPendingExchanges flag to start rebalance

commit 9f5d9f7871ba9cff079a76097bb4f269fd7f7a5b
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-07T20:30:39Z

    IGNITE-7165: rename rebalance assingns needs

commit 4dcb6270d026f36fb7b3ae2b904ce36bc633ac55
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-07T20:35:29Z

    IGNITE-7165: javadoc

commit cccdd69b86ebcce1626dfc9416f32f88e708d4e9
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-08T15:06:39Z

    IGNITE-7165: remove skip rebalance twice

commit 3410aaca6298be1b3b26c5202b43a1b787123396
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-10T13:50:00Z

    IGNITE-7165: calculate assigns on last running topology version

commit 5f98a480a07d2c0504a60763da482c2792540719
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-19T11:00:32Z

    Merge branch 'master' into av-ignite-7165
    
    # Conflicts:
    #   
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPreloader.java

commit cfb9574d65f64660f36689789b0090ef0be50fcb
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-20T16:48:28Z

    IGNITE-7165: keep last rebalance topology version

commit d15515f3ee83455697dead6ff39e75dafebcfd76
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-20T17:10:11Z

    IGNITE-7165: return last rebalance topology version

commit d0d47eb0eda31165f5c8f1e53ef92ecf82d9c548
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-21T10:29:15Z

    IGNITE-7165: default value for rebalance topVer should be null

commit 68d53d7c317ee676c08d45b6a4be360bb4659fb7
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-21T10:30:56Z

    Merge branch 'master' into av-ignite-7165

commit 4cf7c72e9db55d47a305f93c649d29e6557354e2
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-21T10:33:55Z

    IGNITE-7165: debug messages for update topology version

commit 7bd0be89c66bf5bf78f88c5e30d32c70c79a5fcd
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T09:11:33Z

    ignite-7165: skip if null

commit 4b2e232c0d97452986fe79f6c33ec62e5b9ad9a7
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T09:46:34Z

    ignite-7165: java doc update

commit 682194b1597a91a86c4b3546a8f3726bdae07254
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T12:20:11Z

    ignite-7165: move latest ver to rebalance future

commit d9fbea3af09478332347181c3f2b330541a7e7b5
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T14:29:06Z

    ignite-7165: use get topology version method

commit 15d90b01535c9e199286b6cd5cdd16e0eb28e76e
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T14:39:21Z

    ignite-7165: fix javadoc exchange

commit 9568763143cf136cfc4e15ab4076f654c9f78131
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T14:47:16Z

    ignite-7165: remove unnecessary topology check

commit 648ab2df71f4a06e59843371181ba0c075efed2f
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T14:51:34Z

    ignite-7165: java doc fix 2

commit 84d4cfa4b08226f8d2ad8cb163dd3015675692ec
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:00:04Z

    ignite-7165: force rebalance routine

commit 38218eeea65574c8d3965fddaf2b037e60127ac9
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:01:36Z

    ignite-7165: force rebalance 2

commit aa21fd2133b0fca74a135795bbab1393ec56fb87
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:05:38Z

    ignite-7165: simplify topology changed conditions

commit 66b5f76c15cb67b60adeca864a21fdad39acf6f7
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:10:43Z

    ignite-7165: new java doc for assignments

commit a097a153ed637f2928a1c183af28c3050213df08
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:46:56Z

    ignite-7165: reorganize newly added methods

commit a0fca19c12045461ba3fc4bac25b75b27dada7ae
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:50:00Z

    ignite-7165: remove missprint

commit df8fc1e551899cd70f139e646ca7abc348fa12b6
Author: Maxim Muzafarov <maxmuzaf@...>
Date:   2018-06-22T15:53:40Z

    ignite-7165: GridToStringInclude for assignments

----


> Re-balancing is cancelled if client node joins
> ----------------------------------------------
>
>                 Key: IGNITE-7165
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7165
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mikhail Cherkasov
>            Assignee: Maxim Muzafarov
>            Priority: Critical
>              Labels: rebalance
>             Fix For: 2.7
>
>
> Re-balancing is canceled if client node joins. Re-balancing can take hours 
> and each time when client node joins it starts again:
> [15:10:05,700][INFO][disco-event-worker-#61%statement_grid%][GridDiscoveryManager]
>  Added new node to topology: TcpDiscoveryNode 
> [id=979cf868-1c37-424a-9ad1-12db501f32ef, addrs=[0:0:0:0:0:0:0:1, 127.0.0.1, 
> 172.31.16.213], sockAddrs=[/0:0:0:0:0:0:0:1:0, /127.0.0.1:0, 
> /172.31.16.213:0], discPort=0, order=36, intOrder=24, 
> lastExchangeTime=1512907805688, loc=false, ver=2.3.1#20171129-sha1:4b1ec0fe, 
> isClient=true]
> [15:10:05,701][INFO][disco-event-worker-#61%statement_grid%][GridDiscoveryManager]
>  Topology snapshot [ver=36, servers=7, clients=5, CPUs=128, heap=160.0GB]
> [15:10:05,702][INFO][exchange-worker-#62%statement_grid%][time] Started 
> exchange init [topVer=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> crd=false, evt=NODE_JOINED, evtNode=979cf868-1c37-424a-9ad1-12db501f32ef, 
> customEvt=null, allowMerge=true]
> [15:10:05,702][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionsExchangeFuture]
>  Finish exchange future [startVer=AffinityTopologyVersion [topVer=36, 
> minorTopVer=0], resVer=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> err=null]
> [15:10:05,702][INFO][exchange-worker-#62%statement_grid%][time] Finished 
> exchange init [topVer=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> crd=false]
> [15:10:05,703][INFO][exchange-worker-#62%statement_grid%][GridCachePartitionExchangeManager]
>  Skipping rebalancing (nothing scheduled) [top=AffinityTopologyVersion 
> [topVer=36, minorTopVer=0], evt=NODE_JOINED, 
> node=979cf868-1c37-424a-9ad1-12db501f32ef]
> [15:10:08,706][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Cancelled rebalancing from all nodes [topology=AffinityTopologyVersion 
> [topVer=35, minorTopVer=0]]
> [15:10:08,707][INFO][exchange-worker-#62%statement_grid%][GridCachePartitionExchangeManager]
>  Rebalancing scheduled [order=[statementp]]
> [15:10:08,707][INFO][exchange-worker-#62%statement_grid%][GridCachePartitionExchangeManager]
>  Rebalancing started [top=null, evt=NODE_JOINED, 
> node=a8be3c14-9add-48c3-b099-3fd304cfdbf4]
> [15:10:08,707][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=2f6bde48-ffb5-4815-bd32-df4e57dc13e0, partitionsCount=18, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> [15:10:08,707][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=35d01141-4dce-47dd-adf6-a4f3b2bb9da9, partitionsCount=15, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> [15:10:08,708][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=b3a8be53-e61f-4023-a906-a265923837ba, partitionsCount=15, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> [15:10:08,708][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=f825cb4e-7dcc-405f-a40d-c1dc1a3ade5a, partitionsCount=12, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> [15:10:08,708][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=4ae1db91-8b88-4180-a84b-127a303959e9, partitionsCount=11, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> [15:10:08,708][INFO][exchange-worker-#62%statement_grid%][GridDhtPartitionDemander]
>  Starting rebalancing [mode=ASYNC, 
> fromNode=7c286481-7638-49e4-8c68-fa6aa65d8b76, partitionsCount=18, 
> topology=AffinityTopologyVersion [topVer=36, minorTopVer=0], 
> updateSeq=-1754630006]
> so in clusters with a big amount of data and the frequent client left/join 
> events this means that a new server will never receive its partitions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to