[
https://issues.apache.org/jira/browse/IGNITE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated IGNITE-8157:
------------------------------------
Description:
Changes IGNITE-6842 guarantee us stopping all Ignite instances after test
completion by default.
# We should remove a lot of bolerplate code in our test-classes.
e.g.
{code:java|title=BaseDecisionTreeTest.java|borderStyle=solid}
/** {@inheritDoc} */
@Override protected void afterTestsStopped() throws Exception {
stopAllGrids();
}
{code}
# We shuold carefully review whole usages of stopAllGrids method in our
test-classes and remove if it not necessary anymore or change for using in
proper way\position.
e.g.
{code:java|title=TcpClientDiscoverySpiSelfTest.java|borderStyle=solid}
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
stopAllClients(true);
stopAllServers(true);
...
}
{code}
was:
Changes IGNITE-6842 guarantee us stopping all Ignite instances after test
completion by default.
# We should remove a lot of bolerplate code in our test-classes.
e.g.
{code:java|title=BaseDecisionTreeTest.java|borderStyle=solid}
/** {@inheritDoc} */
@Override protected void afterTestsStopped() throws Exception {
stopAllGrids();
}
{code}
# We shuold carefully review whole usages of stopAllGrids method in our
test-classes and remove if it not necessary anymore or change for using in
proper way\position.
e.g.
{code:java|title=TcpClientDiscoverySpiSelfTest.java|borderStyle=solid}
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
stopAllClients(true);
stopAllServers(true);
...
}
{code}
> Remove boilerplate and unused code due to grids stopping by default
> -------------------------------------------------------------------
>
> Key: IGNITE-8157
> URL: https://issues.apache.org/jira/browse/IGNITE-8157
> Project: Ignite
> Issue Type: Task
> Affects Versions: 2.4
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Minor
> Labels: test
> Fix For: 2.6
>
>
> Changes IGNITE-6842 guarantee us stopping all Ignite instances after test
> completion by default.
> # We should remove a lot of bolerplate code in our test-classes.
> e.g.
> {code:java|title=BaseDecisionTreeTest.java|borderStyle=solid}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
> stopAllGrids();
> }
> {code}
> # We shuold carefully review whole usages of stopAllGrids method in our
> test-classes and remove if it not necessary anymore or change for using in
> proper way\position.
> e.g.
> {code:java|title=TcpClientDiscoverySpiSelfTest.java|borderStyle=solid}
> /** {@inheritDoc} */
> @Override protected void afterTest() throws Exception {
> stopAllClients(true);
> stopAllServers(true);
>
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
