[
https://issues.apache.org/jira/browse/IGNITE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340258#comment-16340258
]
Denis Magda edited comment on IGNITE-7504 at 1/25/18 11:13 PM:
---------------------------------------------------------------
[~amalykh] , [~chief] :
* look for TODOs in the doc and help to fix the unclear parts.
* Why is the example class called {{MNISTExample}}? Let's rename it to
DecisionTreesExample. Otherwise, people won't get what's inside.
* The MNISTExampe has several problems itself:
** some of the lines' width takes more than 120 columns
([https://stackoverflow.com/questions/24355976/how-to-change-line-width-in-intellij-from-120-character)]
** {{cfg.setEvictionPolicy(null);}} is deprecated
**
{\{cfg.setAtomicityMode(CacheAtomicityMode.ATOMIC);}}cfg.setCacheMode(CacheMode.PARTITIONED);
cfg.setBackups(0); - these are already default parameters! Clean the code
please.
** the examples requires to preload the datasets. Can't we pick one data set,
add it to the example directory and use by default? Please don't make users
perform the steps that can be automated
was (Author: dmagda):
[~amalykh] , [~chief] :
* look for TODOs in the doc and help to fix the unclear parts.
* Why is the example class called {{MNISTExample}}? Let's rename it to
DecisionTreesExample. Otherwise, people won't get what's inside.
* The MNISTExampe has several problems itself:
** some of the lines' width takes more than 120 columns
([https://stackoverflow.com/questions/24355976/how-to-change-line-width-in-intellij-from-120-character)]
** {{cfg.setEvictionPolicy(null);}} is deprecated
**
{{cfg.setAtomicityMode(CacheAtomicityMode.ATOMIC);}}cfg.setCacheMode(CacheMode.PARTITIONED);
cfg.setBackups(0); - these are already default parameters! Clean the code
please.
> Decision tree documentation
> ---------------------------
>
> Key: IGNITE-7504
> URL: https://issues.apache.org/jira/browse/IGNITE-7504
> Project: Ignite
> Issue Type: Task
> Components: documentation, ml
> Reporter: Yury Babak
> Assignee: Yury Babak
> Priority: Major
> Labels: documentation
> Fix For: 2.4
>
>
> We want to add Decision tree documentation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
